vmstate: fix buffer overflow in target-arm/machine.c
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 3 Apr 2014 16:51:42 +0000 (19:51 +0300)
committerJuan Quintela <quintela@redhat.com>
Mon, 5 May 2014 20:15:02 +0000 (22:15 +0200)
commitd2ef4b61fe6d33d2a5dcf100a9b9440de341ad62
tree2804cfea3f62670d6be57eb102ad929f0a843581
parentd8d0a0bc7e194300e53a346d25fe5724fd588387
vmstate: fix buffer overflow in target-arm/machine.c

CVE-2013-4531

cpreg_vmstate_indexes is a VARRAY_INT32. A negative value for
cpreg_vmstate_array_len will cause a buffer overflow.

VMSTATE_INT32_LE was supposed to protect against this
but doesn't because it doesn't validate that input is
non-negative.

Fix this macro to valide the value appropriately.

The only other user of VMSTATE_INT32_LE doesn't
ever use negative numbers so it doesn't care.

Reported-by: Anthony Liguori <anthony@codemonkey.ws>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
vmstate.c