[iscsi] Always send FirstBurstLength parameter
authorMichael Brown <mcb30@ipxe.org>
Wed, 3 May 2017 12:01:11 +0000 (13:01 +0100)
committerMichael Brown <mcb30@ipxe.org>
Wed, 3 May 2017 12:01:11 +0000 (13:01 +0100)
commit785389c2ba84870e003c23304ca88aa4ec1f144d
treeb1a9f1c2c8181254df89f9f7d02be85d9e533921
parent17887f87b78fe5f0ac52f23a4eb0584794462d84
[iscsi] Always send FirstBurstLength parameter

As of kernel 4.11, the LIO target will propose a value for
FirstBurstLength if the initiator did not do so.  This is entirely
redundant in our case, since FirstBurstLength is defined by RFC 3720
to be

  "Irrelevant when: ( InitialR2T=Yes and ImmediateData=No )"

and we already enforce both InitialR2T=Yes and ImmediateData=No in our
initial proposal.  However, LIO (arguably correctly) complains when we
do not respond to its redundant proposal of an already-irrelevant
value.

Fix by always proposing the default value for FirstBurstLength.

Debugged-by: Patrick Seeburger <info@8bit.de>
Tested-by: Patrick Seeburger <info@8bit.de>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/net/tcp/iscsi.c