[efi] Fix building elf2efi.c when -fpic is enabled by default
authorMichael Brown <mcb30@ipxe.org>
Wed, 25 Jan 2017 08:00:50 +0000 (08:00 +0000)
committerMichael Brown <mcb30@ipxe.org>
Wed, 25 Jan 2017 08:15:21 +0000 (08:15 +0000)
commit941c53a3bf0f0c1c276996e2a68b0fa6263ce410
treeb65062cd2028d35d4688cddb61bbe0e4f74a7a0e
parentbd6255c7be152ea3451dcd6f4175e250bf755f67
[efi] Fix building elf2efi.c when -fpic is enabled by default

The x86_64 EDK2 headers include a #pragma to mark all subsequent
symbol declarations and references as hidden if position-independent
code is being generated.  Since libgen.h is currently included only
after the EDK2 headers, this results in __xpg_basename() being
erroneously marked as having hidden visibility (if the compiler
defaults to building position-independent code); this eventually
results in a failure to link the elf2efi binary.

Fix by including libgen.h prior to including the EDK2 headers.

Originally-fixed-by: Doug Goldstein <cardoe@cardoe.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/util/elf2efi.c