target/arm: Fix temp double-free in sve ldr/str
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 3 Jul 2020 15:59:43 +0000 (16:59 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Fri, 3 Jul 2020 15:59:43 +0000 (16:59 +0100)
commit4b4dc9750a0aa0b9766bd755bf6512a84744ce8a
treeff0f8c53d889055223d3834aab40dadeff562716
parent7fb3949d1f2365548a1d0e64e685642309029494
target/arm: Fix temp double-free in sve ldr/str

The temp that gets assigned to clean_addr has been allocated with
new_tmp_a64, which means that it will be freed at the end of the
instruction.  Freeing it earlier leads to assertion failure.

The loop creates a complication, in which we allocate a new local
temp, which does need freeing, and the final code path is shared
between the loop and non-loop.

Fix this complication by adding new_tmp_a64_local so that the new
local temp is freed at the end, and can be treated exactly like
the non-loop path.

Fixes: bba87d0a0f4
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200702175605.1987125-1-richard.henderson@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
target/arm/translate-a64.c
target/arm/translate-a64.h
target/arm/translate-sve.c