build-sys: do not make qemu-ga link with pixman
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Wed, 11 Mar 2020 16:09:23 +0000 (17:09 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 16 Mar 2020 22:02:22 +0000 (23:02 +0100)
commit5b42bc5ce9ab4a3171819feea5042931817211fd
tree3e6b0c1d1ebd1f04615a055779d9c4b362419f05
parent78b3f67acdf0f646d35ebdf98b9e91fb04ab9a07
build-sys: do not make qemu-ga link with pixman

Since commit d52c454aadcdae74506f315ebf8b58bb79a05573 ("contrib: add
vhost-user-gpu"), qemu-ga is linking with pixman.

This is because the Make-based build-system use a global namespace for
variables, and we rely on "main.o-libs" for different linking targets.

Note: this kind of variable clashing is hard to fix or prevent
currently.  meson should help, as declarations have a linear
dependency and doesn't rely so much on variables and clever tricks.

Note2: we have a lot of main.c (or other duplicated names!) in
tree. Imho, it would be annoying and a bad workaroud to rename all
those to avoid conflicts like I did here.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1811670

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200311160923.882474-1-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
contrib/vhost-user-gpu/Makefile.objs
contrib/vhost-user-gpu/vhost-user-gpu.c [moved from contrib/vhost-user-gpu/main.c with 100% similarity]