tools/virtiofsd/passthrough_ll: Fix double close()
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Sat, 21 Mar 2020 12:06:54 +0000 (13:06 +0100)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 25 Mar 2020 12:31:38 +0000 (12:31 +0000)
commite1cd92d95cd4f97b3464c4e08cd5b22bf5ca05cb
tree7bda276d3ce1fab3d4addffb643fb9289385bc09
parentd4ff109373ce871928c7e9ef648973eba642b484
tools/virtiofsd/passthrough_ll: Fix double close()

On success, the fdopendir() call closes fd. Later on the error
path we try to close an already-closed fd. This can lead to
use-after-free. Fix by only closing the fd if the fdopendir()
call failed.

Cc: qemu-stable@nongnu.org
Fixes: b39bce121b (add dirp_map to hide lo_dirp pointers)
Reported-by: Coverity (CID 1421933 USE_AFTER_FREE)
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200321120654.7985-1-philmd@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
tools/virtiofsd/passthrough_ll.c