block: Fix leak in bdrv_create_file_fallback()
authorMax Reitz <mreitz@redhat.com>
Tue, 25 Feb 2020 15:56:18 +0000 (16:56 +0100)
committerKevin Wolf <kwolf@redhat.com>
Fri, 6 Mar 2020 16:15:37 +0000 (17:15 +0100)
commiteeea1faa099f82328f5831cf252f8ce0a59a9287
tree99a8ba12b38cd0e41ed227b5418e8ae9d0dec391
parent81311255f217859413c94f2cd9cebf2684bbda94
block: Fix leak in bdrv_create_file_fallback()

@options is leaked by the first two return statements in this function.

Note that blk_new_open() takes the reference to @options even on
failure, so all we need to do to fix the leak is to move the QDict
allocation down to where we actually need it.

Reported-by: Coverity (CID 1419884)
Fixes: fd17146cd93d1704cd96d7c2757b325fc7aac6fd
       ("block: Generic file creation fallback")
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200225155618.133412-1-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c