qemu.git
8 years agotarget-sparc: Fix mixup of uint64 and uint64_t
Andreas Färber [Mon, 16 Jan 2012 00:46:51 +0000 (01:46 +0100)] 
target-sparc: Fix mixup of uint64 and uint64_t

Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc:
Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64
type.

Use uint64_t instead.

Signed-off-by: Andreas Färber <afaerber@suse.de>
Cc: Richard Henderson <rth@twiddle.net>
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
8 years agosga: fix copypasta
Blue Swirl [Sun, 23 Oct 2011 14:39:46 +0000 (14:39 +0000)] 
sga: fix copypasta

Fix the name of the init function.

Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
8 years agovga: make Cirrus ISA device optional
Blue Swirl [Sat, 1 Oct 2011 16:33:43 +0000 (16:33 +0000)] 
vga: make Cirrus ISA device optional

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
8 years agovga: improve VGA logic
Blue Swirl [Tue, 27 Sep 2011 19:15:42 +0000 (19:15 +0000)] 
vga: improve VGA logic

Improve VGA selection logic, push check for device availabilty to vl.c.
Create the devices at board level unconditionally.

Remove now unused pci_try_create*() functions.

Make PCI VGA devices optional.

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
8 years agograckle_pci: Clean up qdev names
Andreas Färber [Wed, 18 Jan 2012 00:11:16 +0000 (00:11 +0000)] 
grackle_pci: Clean up qdev names

Rename SysBus device from 'grackle' to 'grackle-pcihost' to resolve a
name conflict.

Also mark both devices as no_user.

Signed-off-by: Andreas Färber <afaerber@suse.de>
Cc: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoMAINTAINERS: Add PCI-PCI bridge to New World Mac machine
Andreas Färber [Wed, 18 Jan 2012 06:20:43 +0000 (06:20 +0000)] 
MAINTAINERS: Add PCI-PCI bridge to New World Mac machine

Signed-off-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: Pseries: Check for PCI boundaries
Alexander Graf [Wed, 18 Jan 2012 15:42:09 +0000 (16:42 +0100)] 
PPC: Pseries: Check for PCI boundaries

We call pci_host_config_{read,write}_common() which perform PCI config
accesses. However they don't do all limit checking the way we expect
it to.

So let's introduce a small wrapper around them, making them behave the
way we would without touching generic code.

This patch is based on a patch by David Gibson which put this logic into
the generic code.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoMAINTAINERS: Add PCI host bridge files to CHRP machines
Andreas Färber [Fri, 13 Jan 2012 13:33:58 +0000 (13:33 +0000)] 
MAINTAINERS: Add PCI host bridge files to CHRP machines

Just like prep_pci.c, these were not associated with any MAINTAINERS
section, including PCI.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoMAINTAINERS: Add qemu-ppc to all ppc target stuff
Andreas Färber [Fri, 13 Jan 2012 13:33:57 +0000 (13:33 +0000)] 
MAINTAINERS: Add qemu-ppc to all ppc target stuff

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agopseries: SLOF PCI flag day
Benjamin Herrenschmidt [Wed, 11 Jan 2012 19:46:28 +0000 (19:46 +0000)] 
pseries: SLOF PCI flag day

Currently on the pseries machine the SLOF firmware is used normally,
but we bypass it when -kernel is specified.  Having these two

different boot paths can cause some confusion.

In particular at present we need to "probe" the (emulated) PCI bus and
produce device tree nodes for the PCI devices in qemu, for the -kernel
case.  In the SLOF case, it takes the device tree from qemu adds some
stuff to it then passes it on to the kernel.

It's been decided that a better approach is to always boot through
SLOF, even when using -kernel.  WIth this approach we can leave PCI
probing and device node creation to SLOF in all cases which removes a
bunch of code in qemu, and avoids iterating the PCI devices from the
machine specific init code which we're not supposed to do.

This patch changes qemu to always boot through SLOF, and not to create
PCI nodes.  Simultaneously it updates the included version of SLOF
(submodule and binary image) to one which supports (and requires) the
new approach.

The new SLOF version also includes a number of unrelated enhancements:
support for booting from virtio-pci devices and e1000, greatly
improved FCode support and many bugfixes.  It also makes SLOF ready to
be used even when specifying a kernel on the qemu command line.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agopseries: Use correct dispatcher for PCI config space accesses
David Gibson [Wed, 11 Jan 2012 19:46:26 +0000 (19:46 +0000)] 
pseries: Use correct dispatcher for PCI config space accesses

The pseries machine expects a para-virtualized guest and so supplies RTAS
functions (via a hypercall) for performing PCI config space access.
Currently the implementation of these calls into
pci_default_{read,write}_config().  However this would be incorrect for
any PCI device which overrides the default config read/write functions.
AFAICT there's only one such device today, but we should still get it
right.  In addition the pci_host_config_{read,write}_common() functions
which do correctly do this dispatch, perform bounds checking on the config
space address, lack of which currently leads to an exploitable bug.

This patch corrects the problem.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agopseries: Support PCI extended config space in RTAS calls
Benjamin Herrenschmidt [Wed, 11 Jan 2012 19:46:25 +0000 (19:46 +0000)] 
pseries: Support PCI extended config space in RTAS calls

On the pseries machine (which expexts a paravirtualized guest), guest
access to PCI config space is via host-provided RTAS functions.  This
patch extends these RTAS functions to permit access to PCI extended
config space, as specified in PAPR.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoCorrect types in bmdma_addr_{read,write}
David Gibson [Wed, 11 Jan 2012 19:46:24 +0000 (19:46 +0000)] 
Correct types in bmdma_addr_{read,write}

Back when I made patches introducing dma_addr_t and various PCI DMA
wrapper functions, I made a mistake.  The bmdma_addr_{read,write} functions
need to take target_phys_addr_t not dma_addr_t, since they are assigned
to MemoryRegionOps callbacks.

This patch corrects my error.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoUpdate gitignore file
David Gibson [Wed, 11 Jan 2012 19:46:23 +0000 (19:46 +0000)] 
Update gitignore file

This patch adds several auto-generated files to .gitignore which were
previously missing.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoFix dirty logging with 32-bit qemu & 64-bit guests
Benjamin Herrenschmidt [Wed, 11 Jan 2012 19:46:21 +0000 (19:46 +0000)] 
Fix dirty logging with 32-bit qemu & 64-bit guests

The kvm_get_dirty_pages_log_range() function uses two address
variables to step through the monitored memory region to update the
dirty log.  However, these variables have type unsigned long, which
can overflow if running a 64-bit guest with a 32-bit qemu binary.

This patch changes these to target_phys_addr_t which will have the
correct size.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoload_image_targphys() should enforce the max size
Benjamin Herrenschmidt [Wed, 11 Jan 2012 19:46:20 +0000 (19:46 +0000)] 
load_image_targphys() should enforce the max size

load_image_targphys() gets passed a max size for the file, but doesn't
enforce it at all. Add a check and return -1 (error) if the file is
too big, without loading it.  Fix the bracing style in the function
while we're at it.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agovirtio: change memcpy to guest reads
Alexander Graf [Tue, 10 Jan 2012 22:33:10 +0000 (23:33 +0100)] 
virtio: change memcpy to guest reads

When accessing the device specific virtio config space, we memcpy
the data into a variable in QEMU. At that point we're basically
pulling host endianness into the game which is a really bad idea.

So instead, let's use the target specific load/store helpers for
memory pointers which fetch things in target endianness. The whole
array is already populated in target endianness anyways
(see virtio-blk).

Signed-off-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agovirtio-pci: Fix endianness of virtio config
Benjamin Herrenschmidt [Tue, 10 Jan 2012 01:35:11 +0000 (01:35 +0000)] 
virtio-pci: Fix endianness of virtio config

The virtio config area in PIO space is a bit special. The initial
header is little endian but the rest (device specific) is guest
native endian.

The PIO accessors for PCI on machines that don't have native IO ports
assume that all PIO is little endian, which works fine for everything
except the above.

A complicated way to fix it would be to split the BAR into two memory
regions with different endianess settings, but this isn't practical
to do, besides, the PIO code doesn't honor region endianness anyway
(I have a patch for that too but it isn't necessary at this stage).

So I decided to go for the quick fix instead which consists of
reverting the swap in virtio-pci in selected places, hoping that when
we eventually do a "v2" of the virtio protocols, we sort that out once
and for all using a fixed endian setting for everything.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
[agraf: keep virtio in libhw and determine endianness through a
        helper function in exec.c]
Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agoPPC: Bamboo: Integrate SoC instatiation, use qdev for PCI
Alexander Graf [Tue, 10 Jan 2012 19:11:25 +0000 (20:11 +0100)] 
PPC: Bamboo: Integrate SoC instatiation, use qdev for PCI

Now that we have the SoC init function in the same file, let's integrate
it with the board initialization.

While at it, also make use of the newly qdev'ified PCI host controller.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: Bamboo: fold ppc440.c and ppc440_bamboo.c into a single file
Alexander Graf [Tue, 10 Jan 2012 18:39:38 +0000 (19:39 +0100)] 
PPC: Bamboo: fold ppc440.c and ppc440_bamboo.c into a single file

The separation of ppc440 and ppc440_bamboo makes some sense, since ppc440
is the SoC while ppc440_bamboo is the actual board. But the separation
makes things harder for us for no good reason, so let's just fold them
in together with each other.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: 4xx: Qdevify the 440 PCI host controller
Alexander Graf [Tue, 10 Jan 2012 18:36:26 +0000 (19:36 +0100)] 
PPC: 4xx: Qdevify the 440 PCI host controller

Due to popular demand, this qdevifies the PCI host controller of 4xx SoCs
the same way as e500.

We have to introduce a small stub function for pci init that will be
removed in a later patch, once we qdev'ified the board, to keep the build
working.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: bamboo: fix whitespace
Alexander Graf [Tue, 10 Jan 2012 15:49:22 +0000 (16:49 +0100)] 
PPC: bamboo: fix whitespace

Tabs followed by spaces are a no-go. My editor shows it red, distracting
me from actual work! :)

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: bamboo: remove old machine descriptions
Alexander Graf [Tue, 10 Jan 2012 15:36:10 +0000 (16:36 +0100)] 
PPC: bamboo: remove old machine descriptions

Nobody needs to run bamboo in 0.12 compat mode. Remove the machine.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: Enable 440EP CPU target
Alexander Graf [Tue, 3 Jan 2012 21:01:40 +0000 (22:01 +0100)] 
PPC: Enable 440EP CPU target

Now that we have 440 TLB emulation, we can also support running the 440EP
CPU target in system emulation mode.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: 440: Default to 440EP CPU
Alexander Graf [Tue, 3 Jan 2012 21:00:23 +0000 (22:00 +0100)] 
PPC: 440: Default to 440EP CPU

Today we're exposing a Virtex 440 CPU to the guest despite the fact
that we're telling the guest that we're running on a 440EP one in the
device tree.

So let's better default to a real 440EP to make things synced again.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: Bamboo: recompile device tree
Alexander Graf [Tue, 3 Jan 2012 20:58:57 +0000 (21:58 +0100)] 
PPC: Bamboo: recompile device tree

Recent dtc doesn't compile our dts anymore. Change all hex numbers to have
0x prefixes, indicate the old version and recompile using recent dtc.

This doesn't change any semantics in the device tree.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: 440: Ignore invalid PCI IRQs
Alexander Graf [Tue, 3 Jan 2012 18:15:16 +0000 (19:15 +0100)] 
PPC: 440: Ignore invalid PCI IRQs

When running a 440 target, we currently get invalid irq_num values (-1)
which completely confuse the IRQ setting code.

This is most likely due to the missing qdev conversion.

While this shouldn't happen in the first place and should really rather
be fixed by converting the target, I dislike segfaults. So for now, let's
just print a warning and ignore invalid irq_num values.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: Bamboo: Set initial TLB entry
Alexander Graf [Tue, 3 Jan 2012 18:12:47 +0000 (19:12 +0100)] 
PPC: Bamboo: Set initial TLB entry

Back in the day when the bamboo target got introduced, the initial TLB was
dictated by KVM. TCG has been missing initial TLB values ever since, rendering
the target unusable for TCG usage.

This patch adds linear TLB maps the way Linux expects them, making the target
work.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: Bamboo: Register CPU reset
Alexander Graf [Tue, 3 Jan 2012 18:10:02 +0000 (19:10 +0100)] 
PPC: Bamboo: Register CPU reset

To be able to support CPU reset, we need to put all register initialization
and initial state into a CPU reset hook instead of a function that is only
called once on bootup.

This is a preparation step for the initial TLB setting code and brings bamboo
more in line with what e500 and virtex already do.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoPPC: 440EP: Initialize timer
Alexander Graf [Tue, 3 Jan 2012 17:55:38 +0000 (18:55 +0100)] 
PPC: 440EP: Initialize timer

When using TCG with a BookE PowerPC core, we need to explicitly initialize
the BookE timers with the correct frequencies.

This was missing for 440EP, since that code came from KVM and was never used
with TCG.

Signed-off-by: Alexander Graf <agraf@suse.de>
8 years agoMerge remote-tracking branch 'spice/spice.v47' into staging
Anthony Liguori [Thu, 19 Jan 2012 18:51:02 +0000 (12:51 -0600)] 
Merge remote-tracking branch 'spice/spice.v47' into staging

* spice/spice.v47:
  qxl: Slot sanity check in qxl_phys2virt() is off by one, fix

8 years agoMerge remote-tracking branch 'stefanha/trivial-patches' into staging
Anthony Liguori [Thu, 19 Jan 2012 15:23:59 +0000 (09:23 -0600)] 
Merge remote-tracking branch 'stefanha/trivial-patches' into staging

* stefanha/trivial-patches:
  Makefile: Remove generated headers on clean
  Makefile: Exclude tests/Makefile in unconfigured tree
  lm32: Fix mixup of uint32 and uint32_t
  tests: Silence gtester in Makefile
  qemu-tool: Fix mixup of int64 and int64_t

8 years agoMerge remote-tracking branch 'qmp/queue/qmp' into staging
Anthony Liguori [Thu, 19 Jan 2012 15:23:16 +0000 (09:23 -0600)] 
Merge remote-tracking branch 'qmp/queue/qmp' into staging

* qmp/queue/qmp:
  block: use proper qerrors in qmp_block_resize
  qerror: restore alphabetical order over qerrors
  qerror: add check-qerror.sh to verify alphabetical order
  qmp: Add missing gcc format attribute and fix format string
  qapi: Convert block_set_io_throttle
  qapi: Convert change
  qerror: Extend QERR_DEVICE_ENCRYPTED
  qapi: Introduce change-vnc-password
  monitor: expose readline state
  qapi: Convert eject
  block: eject_device(): Use error_set()
  qapi: Convert expire_password
  qapi: Convert set_password
  vnc: Simplify vnc_display_password()

8 years agoMerge remote-tracking branch 'pmaydell/arm-devs.for-upstream' into staging
Anthony Liguori [Thu, 19 Jan 2012 15:19:44 +0000 (09:19 -0600)] 
Merge remote-tracking branch 'pmaydell/arm-devs.for-upstream' into staging

* pmaydell/arm-devs.for-upstream:
  arm: make the number of GIC interrupts configurable
  hw/lan9118: Add save/load support
  arm: Remove incorrect comment in arm_timer
  vexpress, realview: Add (dummy) L2 cache controller

8 years agoMerge remote-tracking branch 'kraxel/usb.37' into staging
Anthony Liguori [Thu, 19 Jan 2012 14:34:38 +0000 (08:34 -0600)] 
Merge remote-tracking branch 'kraxel/usb.37' into staging

* kraxel/usb.37:
  usb-redir: Improve some debugging messages
  usb-redir: Try to keep our buffer size near the target size
  usb-redir: Pre-fill our isoc input buffer before sending pkts to the host
  usb-redir: Dynamically adjust iso buffering size based on ep interval
  usb-redir: Clear iso / irq error when stopping the stream
  usb: link packets to endpoints not devices
  usb: add max_packet_size to USBEndpoint
  usb/debug: add usb_ep_dump
  usb-desc: USBEndpoint support
  usb: add ifnum to USBEndpoint
  usb: add USBEndpoint
  xhci: Initial xHCI implementation
  usb: add audio device model
  usb-desc: audio endpoint support
  usb: track altsetting in USBDevice
  usb: track configuration and interface count in USBDevice.
  usb-host: rip out legacy procfs support

8 years agoMakefile: Remove generated headers on clean
Andreas Färber [Tue, 17 Jan 2012 12:17:38 +0000 (13:17 +0100)] 
Makefile: Remove generated headers on clean

Running `make distclean' followed by a new out-of-tree build would fail
due to stale generated QMP headers in the tree.

Commit 611b727374ad76fb0078ea65bc1387194913980e (Makefile: remove more
generated files on clean) made sure generated sources are removed.

Also remove generated headers introduced in commit
e3193601c84558c303b1773379da76fce80c0a56 (qapi: use middle mode in QMP
server).

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agoMakefile: Exclude tests/Makefile in unconfigured tree
Andreas Färber [Tue, 17 Jan 2012 12:16:05 +0000 (13:16 +0100)] 
Makefile: Exclude tests/Makefile in unconfigured tree

Since commit dbfe06c62ccedc5b64e1c6466445133dd50f6de1 (build:
split unit test builds to a separate makefile fragment),
in absence of config-host.mak an undefined $(SRC_PATH) breaks
`make distclean' due to /tests/Makefile not being include'able.

Fix by only including when config-host.mak is present.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agolm32: Fix mixup of uint32 and uint32_t
Andreas Färber [Tue, 17 Jan 2012 09:44:40 +0000 (10:44 +0100)] 
lm32: Fix mixup of uint32 and uint32_t

Commit d23948b15a9920fb7f6374b55a6db1ecff81f3ee (lm32: add Milkymist
VGAFB support) introduced a stray usage of the softfloat uint32 type.

Use uint32_t instead.

Signed-off-by: Andreas Färber <afaerber@suse.de>
Acked-by: Michael Walle <michael@walle.cc>
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agotests: Silence gtester in Makefile
Stefan Weil [Mon, 16 Jan 2012 06:26:27 +0000 (07:26 +0100)] 
tests: Silence gtester in Makefile

This prettifies make output a little by avoiding a very long line.
As gtester prints the checks when they are run, no information is lost.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agoqemu-tool: Fix mixup of int64 and int64_t
Andreas Färber [Mon, 16 Jan 2012 00:46:52 +0000 (01:46 +0100)] 
qemu-tool: Fix mixup of int64 and int64_t

Commit cbcfa0418f0c196afa765f5c9837b9344d1adcf3 (link the main loop and
its dependencies into the tools) introduced stray usages of int64.

Use int64_t instead.

Signed-off-by: Andreas Färber <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agoblock: use proper qerrors in qmp_block_resize
Stefan Hajnoczi [Wed, 4 Jan 2012 22:23:34 +0000 (22:23 +0000)] 
block: use proper qerrors in qmp_block_resize

Let's report specific errors so that management tools and users can
identify the problem.

Two new qerrors are needed:
 * QERR_DEVICE_HAS_NO_MEDIUM for ENOMEDIUM
 * QERR_DEVICE_IS_READ_ONLY for EACCES

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqerror: restore alphabetical order over qerrors
Stefan Hajnoczi [Wed, 4 Jan 2012 17:38:22 +0000 (17:38 +0000)] 
qerror: restore alphabetical order over qerrors

Over time these must have gotten out of order.  Put everything back in
alphabetical order.

This is purely a clean up.  In practice nothing depends on the order.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqerror: add check-qerror.sh to verify alphabetical order
Stefan Hajnoczi [Wed, 4 Jan 2012 22:23:32 +0000 (22:23 +0000)] 
qerror: add check-qerror.sh to verify alphabetical order

We're supposed to keep qerror definitions and table entries in
alphabetical order.  In practice this is not checked.

I haven't found a nice way to integrate this into the makefile yet but
we can at least have this script which verifies that qerrors are in
alphabetical order.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqmp: Add missing gcc format attribute and fix format string
Stefan Weil [Fri, 23 Dec 2011 19:34:38 +0000 (20:34 +0100)] 
qmp: Add missing gcc format attribute and fix format string

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqapi: Convert block_set_io_throttle
Luiz Capitulino [Wed, 14 Dec 2011 18:49:14 +0000 (16:49 -0200)] 
qapi: Convert block_set_io_throttle

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqapi: Convert change
Luiz Capitulino [Thu, 8 Dec 2011 13:13:50 +0000 (11:13 -0200)] 
qapi: Convert change

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqerror: Extend QERR_DEVICE_ENCRYPTED
Luiz Capitulino [Tue, 13 Dec 2011 19:18:30 +0000 (17:18 -0200)] 
qerror: Extend QERR_DEVICE_ENCRYPTED

Include the name of the encrypted file.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqapi: Introduce change-vnc-password
Luiz Capitulino [Thu, 8 Dec 2011 13:45:55 +0000 (11:45 -0200)] 
qapi: Introduce change-vnc-password

New QMP command to change the VNC password.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agomonitor: expose readline state
Anthony Liguori [Fri, 2 Sep 2011 17:34:50 +0000 (12:34 -0500)] 
monitor: expose readline state

HMP is now implemented in terms of QMP.  The monitor has a bunch of logic to
deal with HMP right now like readline support.  Export it from the monitor so
we can consume it in hmp.c.

In short time, hmp.c will take over all of the readline bits.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqapi: Convert eject
Luiz Capitulino [Wed, 7 Dec 2011 18:02:36 +0000 (16:02 -0200)] 
qapi: Convert eject

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoblock: eject_device(): Use error_set()
Luiz Capitulino [Wed, 7 Dec 2011 17:47:23 +0000 (15:47 -0200)] 
block: eject_device(): Use error_set()

Also drops the leftover 'mon' argument.

This is a preparation for the next commits which will port the
eject and change commands to the QAPI.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqapi: Convert expire_password
Luiz Capitulino [Wed, 7 Dec 2011 13:47:57 +0000 (11:47 -0200)] 
qapi: Convert expire_password

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqapi: Convert set_password
Luiz Capitulino [Wed, 7 Dec 2011 13:17:51 +0000 (11:17 -0200)] 
qapi: Convert set_password

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agovnc: Simplify vnc_display_password()
Luiz Capitulino [Wed, 7 Dec 2011 12:19:10 +0000 (10:19 -0200)] 
vnc: Simplify vnc_display_password()

Drop the qerror_report() call from it and let its callers set the error
themselves. This also allows for dropping the 'ret' variable.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
8 years agoqxl: Slot sanity check in qxl_phys2virt() is off by one, fix
Markus Armbruster [Fri, 4 Nov 2011 09:34:24 +0000 (10:34 +0100)] 
qxl: Slot sanity check in qxl_phys2virt() is off by one, fix

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agoarm: make the number of GIC interrupts configurable
Mark Langsdorf [Tue, 17 Jan 2012 10:54:07 +0000 (10:54 +0000)] 
arm: make the number of GIC interrupts configurable

Increase the maximum number of GIC interrupts for a9mp and a11mp to 1020,
and create a configurable property for each defaulting to 96 and 64
(respectively) so that device modelers can set the value appropriately
for their SoC. Other ARM processors also set their maximum number of
used IRQs appropriately.

Set the maximum theoretical number of GIC interrupts to 1020 and
update the save/restore code to only use the appropriate number for
each SoC.

Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
[Peter Maydell: fixed minor whitespace snafu]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
8 years agohw/lan9118: Add save/load support
Peter Maydell [Tue, 17 Jan 2012 10:54:07 +0000 (10:54 +0000)] 
hw/lan9118: Add save/load support

Implement save/load for the LAN9118.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
8 years agoarm: Remove incorrect comment in arm_timer
Mark Langsdorf [Tue, 17 Jan 2012 10:54:07 +0000 (10:54 +0000)] 
arm: Remove incorrect comment in arm_timer

The current comment says that the arm_timers are restricted to between
32 KHz and 1 MHz, but sp804 TRM does not specify those limits.

Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
8 years agovexpress, realview: Add (dummy) L2 cache controller
Peter Maydell [Tue, 17 Jan 2012 10:54:07 +0000 (10:54 +0000)] 
vexpress, realview: Add (dummy) L2 cache controller

Instantiate the L2 cache controller on the ARM devboards which have one,
since we have a dummy model of it now. Note that the only non-MP board
with an L2x0 is the PB1176, which we don't model.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
8 years agousb-redir: Improve some debugging messages
Hans de Goede [Tue, 10 Jan 2012 13:13:08 +0000 (14:13 +0100)] 
usb-redir: Improve some debugging messages

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb-redir: Try to keep our buffer size near the target size
Hans de Goede [Tue, 10 Jan 2012 13:13:07 +0000 (14:13 +0100)] 
usb-redir: Try to keep our buffer size near the target size

Before this patch we would allow the (iso) buffer to grow unlimited
(and it would under certain circumstances) leading to way too high
latencies for iso data streams.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb-redir: Pre-fill our isoc input buffer before sending pkts to the host
Hans de Goede [Tue, 10 Jan 2012 13:13:06 +0000 (14:13 +0100)] 
usb-redir: Pre-fill our isoc input buffer before sending pkts to the host

This is something which should have been done from the first version of
usb-redir, but wasn't.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb-redir: Dynamically adjust iso buffering size based on ep interval
Hans de Goede [Tue, 10 Jan 2012 13:13:05 +0000 (14:13 +0100)] 
usb-redir: Dynamically adjust iso buffering size based on ep interval

Note the bufpq_target_size id stored in the endpoint info struct,
even though it only used once. This is done because it will be
referenced from other code in a follow up patch.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb-redir: Clear iso / irq error when stopping the stream
Hans de Goede [Tue, 10 Jan 2012 13:13:04 +0000 (14:13 +0100)] 
usb-redir: Clear iso / irq error when stopping the stream

And ignore status messages from the client which arrive after stream
stop (the stream stop send to the client and an error status reported by
the client my cross each other due to network latency).

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb: link packets to endpoints not devices
Gerd Hoffmann [Tue, 13 Dec 2011 14:58:19 +0000 (15:58 +0100)] 
usb: link packets to endpoints not devices

Add USBEndpoint for the control endpoint to USBDevices.  Link async
packets to the USBEndpoint instead of the USBDevice.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb: add max_packet_size to USBEndpoint
Gerd Hoffmann [Wed, 31 Aug 2011 14:09:27 +0000 (16:09 +0200)] 
usb: add max_packet_size to USBEndpoint

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb/debug: add usb_ep_dump
Gerd Hoffmann [Mon, 29 Aug 2011 11:45:25 +0000 (13:45 +0200)] 
usb/debug: add usb_ep_dump

Add function to dump endpoint data, for debugging purposes.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb-desc: USBEndpoint support
Gerd Hoffmann [Tue, 30 Aug 2011 14:42:03 +0000 (16:42 +0200)] 
usb-desc: USBEndpoint support

Initialize USBEndpoint structs from USBDesc* data.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb: add ifnum to USBEndpoint
Gerd Hoffmann [Mon, 29 Aug 2011 10:57:48 +0000 (12:57 +0200)] 
usb: add ifnum to USBEndpoint

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agousb: add USBEndpoint
Gerd Hoffmann [Mon, 29 Aug 2011 10:49:46 +0000 (12:49 +0200)] 
usb: add USBEndpoint

Start maintaining endpoint state at USBDevice level.  Add USBEndpoint
struct and some helper functions to deal with it.  For now it contains
the endpoint type only.  Moved over some bits from usb-linux.c

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agoxhci: Initial xHCI implementation
Hector Martin [Sun, 27 Feb 2011 20:09:09 +0000 (21:09 +0100)] 
xhci: Initial xHCI implementation

Based on the implementation from Hector Martin <hector@marcansoft.com>

Hectors's implementation completely sidestepped the qemu usb system and
used libusb directly for usb device pass through.  So I've ripped out
the libusb bits (or left them in disabled, as reference for further
coding) and hooked up the qemu subsystem instead.  That work is not
complete yet though, partly due to limitations of the qemu usb
subsystem.  Nevertheless I think it is better to continue development
in-tree, especially as the qemu usb bits need a bunch of improvements
too for decent usb 3.0 support.

Current state:
  - usb-storage emulation should work ok.
  - Devices which need constant polling (HID emulation like usb-tablet)
    are known to not work.
  - ISO xfers are not implemented yet.
  - superspeed ports are not implemented yet.
  - usb pass-through is completely untested so far.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
8 years agopxa2xx_keypad: fix unbalanced parenthesis.
Andrzej Zaborowski [Tue, 17 Jan 2012 01:14:42 +0000 (02:14 +0100)] 
pxa2xx_keypad: fix unbalanced parenthesis.

Breakage introduced by me when ammending a previous patch, sorry.

8 years agohw/arm_boot.c: Make SMP boards specify address to poll in bootup loop
Evgeny Voevodin [Fri, 13 Jan 2012 20:52:40 +0000 (20:52 +0000)] 
hw/arm_boot.c: Make SMP boards specify address to poll in bootup loop

The secondary CPU bootloader in arm_boot.c holds secondary CPUs in a
pen until the primary CPU releases them. Make boards specify the
address to be polled to determine whether to leave the pen (it was
previously hardcoded to 0x10000030, which is a Versatile Express/
Realview specific system register address).

Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
8 years agohw/sysbus.h: Increase maximum number of device IRQs.
Evgeny Voevodin [Tue, 17 Jan 2012 01:08:19 +0000 (02:08 +0100)] 
hw/sysbus.h: Increase maximum number of device IRQs.

Samsung exynos4210 Interrupt Combiner needs 512 IRQ sources.

Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
8 years agopxa2xx_keypad: make single automatic scans work
Vasily Khoruzhick [Thu, 12 Jan 2012 19:30:34 +0000 (22:30 +0300)] 
pxa2xx_keypad: make single automatic scans work

u-boot uses single automatic scans and polling in
pxa2xx_keypad driver, so clear KPC_AS bit immediately
and update keys state even if KPC_AS and KPC_ASACT are
cleared.

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
8 years agopxa2xx_lcd: fix palette parser
Vasily Khoruzhick [Thu, 12 Jan 2012 19:30:35 +0000 (22:30 +0300)] 
pxa2xx_lcd: fix palette parser

Pallete entry size for 16bpp format is 2 bytes, not 4

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
8 years agoseabios: Update to release 1.6.3.1
Jan Kiszka [Sun, 15 Jan 2012 16:48:25 +0000 (17:48 +0100)] 
seabios: Update to release 1.6.3.1

User visible changes in seabios:
 - Probe HPET existence (fix for -no-hpet)
 - Probe PCI existence (fix for -machine isapc)
 - usb: fix boot paths

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
8 years agoisapc: Fix segfault during initialization
Jan Kiszka [Sat, 14 Jan 2012 13:08:28 +0000 (14:08 +0100)] 
isapc: Fix segfault during initialization

Obviously, linking the RTC device state to the PIIX does not belong into
the common path that is shared with the isapc.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
8 years agokvm: flush the dirty log when unregistering a slot
Avi Kivity [Sun, 15 Jan 2012 14:13:59 +0000 (16:13 +0200)] 
kvm: flush the dirty log when unregistering a slot

Otherwise, the dirty log information is lost in the kernel forever.

Fixes opensuse-12.1 boot screen, which changes the vga windows rapidly.

Signed-off-by: Avi Kivity <avi@redhat.com>
8 years agoarm: Add dummy support for co-processor 15's secure config register
Rob Herring [Fri, 13 Jan 2012 17:25:08 +0000 (17:25 +0000)] 
arm: Add dummy support for co-processor 15's secure config register

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
8 years agotarget-arm: Fix errors in decode of M profile CPS
Peter Maydell [Fri, 13 Jan 2012 17:25:08 +0000 (17:25 +0000)] 
target-arm: Fix errors in decode of M profile CPS

Fix errors in the decode of M profile CPS:
 * the decode of the I (affects PRIMASK) and F (affects FAULTMASK)
   bits was reversed
 * the FAULTMASK system register number is 19, not 17

This fixes an issue reported as LP:913925.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
8 years agoprepare for future GPLv2+ relicensing
Paolo Bonzini [Fri, 13 Jan 2012 16:44:23 +0000 (17:44 +0100)] 
prepare for future GPLv2+ relicensing

All files under GPLv2 will get GPLv2+ changes starting tomorrow.
event_notifier.c and exec-obsolete.h were only ever touched by Red Hat
employees and can be relicensed now.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agovirtio-console: no need to remove char handlers explicitly
Amit Shah [Fri, 13 Jan 2012 09:59:48 +0000 (15:29 +0530)] 
virtio-console: no need to remove char handlers explicitly

qdev is now equipped (thanks to the last commit) to disassociate
chardevs from the qdev devices on the devices going away.  So doing it
in the virtio-console driver is not necessary.

Since that was the only thing being done in the qdev exit method, drop
it entirely.

Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agoqdev: Add a 'free' method to disassociate chardev from qdev device
Amit Shah [Fri, 13 Jan 2012 09:59:47 +0000 (15:29 +0530)] 
qdev: Add a 'free' method to disassociate chardev from qdev device

When a device is removed, remove the association with a chardev, if any,
so that the chardev can be re-used later for other devices.

Reported-by: Qunfang Zhang <qzhang@redhat.com>
Fix-suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agovectorize is_dup_page
Paolo Bonzini [Fri, 23 Dec 2011 15:17:26 +0000 (16:17 +0100)] 
vectorize is_dup_page

is_dup_page is already proceeding in 32-bit chunks.  Changing it
to 16 bytes using Altivec or SSE is easy.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agovirtio-blk: refuse SG_IO requests with scsi=off
Paolo Bonzini [Fri, 23 Dec 2011 14:39:03 +0000 (15:39 +0100)] 
virtio-blk: refuse SG_IO requests with scsi=off

QEMU does have a "scsi" option (to be used like -device
virtio-blk-pci,drive=foo,scsi=off).  However, it only
masks the feature bit, and does not reject the command
if a malicious guest disregards the feature bits and
issues a request.

Without this patch, using scsi=off does not protect you
from CVE-2011-4127.

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agovmstate: extract declarations out of hw/hw.h
Paolo Bonzini [Fri, 13 Jan 2012 16:07:20 +0000 (17:07 +0100)] 
vmstate: extract declarations out of hw/hw.h

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agoptimer: move declarations to ptimer.h
Paolo Bonzini [Fri, 13 Jan 2012 16:07:19 +0000 (17:07 +0100)] 
ptimer: move declarations to ptimer.h

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agortc: clear non-PF bits when reinjecting on ack
Paolo Bonzini [Mon, 21 Nov 2011 18:00:31 +0000 (19:00 +0100)] 
rtc: clear non-PF bits when reinjecting on ack

When an rtc interrupt is reinjected immediately after being acked,
other interrupts should not be reinjected, so do clear their bits.

Also, if the periodic interrupts have been disabled before acking,
do not reinject, as the guest might get very confused!

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agortc: raise PF bit when the periodic timer triggers but PIE=0
Paolo Bonzini [Mon, 21 Nov 2011 18:00:30 +0000 (19:00 +0100)] 
rtc: raise PF bit when the periodic timer triggers but PIE=0

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agortc: raise AF bit when the alarm is encountered but AIE=0
Paolo Bonzini [Mon, 21 Nov 2011 18:00:29 +0000 (19:00 +0100)] 
rtc: raise AF bit when the alarm is encountered but AIE=0

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agortc: fix 12-hour mode
Paolo Bonzini [Mon, 21 Nov 2011 18:00:28 +0000 (19:00 +0100)] 
rtc: fix 12-hour mode

Hours in 12-hour mode are in the 1-12 range, not 0-11.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agoqdev: fix device_del by refactoring reference counting
Anthony Liguori [Fri, 13 Jan 2012 13:45:55 +0000 (07:45 -0600)] 
qdev: fix device_del by refactoring reference counting

Commit 8eb0283 broken device_del by having too overzealous reference counting
checks.  Move the reference count checks to qdev_free(), make sure to remove
the parent link on free, and decrement the reference count on property removal.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
8 years agoMerge remote-tracking branch 'stefanha/trivial-patches' into HEAD
Anthony Liguori [Fri, 13 Jan 2012 16:17:49 +0000 (10:17 -0600)] 
Merge remote-tracking branch 'stefanha/trivial-patches' into HEAD

* stefanha/trivial-patches:
  bt-host: add missing break statement
  virtfs-proxy-helper: Add missing printf format attribute
  virtfs-proxy-helper: Clean include files
  virtfs-proxy-helper: Fix compilation on newer systems
  hmp: Fix freeing of PciInfoList
  Add 'fall through' comments to case statements without break
  omap_dss: correct chip[1] index in RFBI_READ/RFBI_STATUS
  vnc: fix no-lock-key-sync strncmp() length
  vvfat: avoid leaking file descriptor in commit_one_file()
  Spelling fixes in comments and documentation
  tcg-arm: fix a typo in comments
  configure: Modify detection of supported warning options

8 years agotarget-i386: fix compilation with --enable-debug-tcg
Aurelien Jarno [Fri, 13 Jan 2012 15:01:40 +0000 (16:01 +0100)] 
target-i386: fix compilation with --enable-debug-tcg

Commit 2355c16e74ffa4d14e7fc2b4a23b055565ac0221 introduced a new ldmxcsr
helper taking an i32 argument, but the helper is actually passed a long.
Fix that by truncating the long to i32.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
8 years agobt-host: add missing break statement
Stefan Hajnoczi [Thu, 12 Jan 2012 14:17:04 +0000 (14:17 +0000)] 
bt-host: add missing break statement

The switch statement in bt_host_read() is missing a break in one case.
Andrzej Zaborowski <andrew.zaborowski@intel.com> confirmed that this is
not an intentional fall-through.

Reviewed-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agovirtfs-proxy-helper: Add missing printf format attribute
Stefan Weil [Wed, 11 Jan 2012 18:47:37 +0000 (19:47 +0100)] 
virtfs-proxy-helper: Add missing printf format attribute

Every function with printf like arguments must have it
(see file HACKING), so add it.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agovirtfs-proxy-helper: Clean include files
Stefan Weil [Wed, 11 Jan 2012 18:34:30 +0000 (19:34 +0100)] 
virtfs-proxy-helper: Clean include files

The common standard include files are already included via qemu-common.h,
and for the socket related include files there is qemu_socket.h, so the
code can be reduced by some lines.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agovirtfs-proxy-helper: Fix compilation on newer systems
Stefan Weil [Wed, 11 Jan 2012 18:34:29 +0000 (19:34 +0100)] 
virtfs-proxy-helper: Fix compilation on newer systems

Include file attr/xattr.h is not available on "newer" systems
(for example Fedora 12 or Debian Squeeze).

See comments in qemu-xattr.h for more information.
This file handles the system dependencies automatically.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
8 years agohmp: Fix freeing of PciInfoList
Stefan Berger [Wed, 11 Jan 2012 15:51:52 +0000 (10:51 -0500)] 
hmp: Fix freeing of PciInfoList

Remember the original PciInfoList in info_list and use
the info variable to traverse the list.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>